Garage door notifications

[ryanobrian]

1) Give a description of the problem
I get inconsistent notifications from these pistons I created. I assume it’s because I"m new to this and I didn’t build them right

2) What is the expected behaviour?
If the time is between 630pm and 630 AM mon-fri and the garage door is opened it should send an email notification

3) What is happening/not happening?

This works inconsistently… I dont think I built it right?

**4) Post a Green Snapshot of the piston![image|45x37]

I also have a seperate piston for when they are closed… but I suspect I can merge them togather?

[Pantheon]

I have not had time to dig into this, but I did notice a couple of things right away.

1. Is your line 33 - Until {GarageDoors}'s contact changes to closed - ALL or ANY?

I used to group all of mine in a device variable like you have defined. But when looking at the code outside of edit mode, I cannot tell the difference between ALL or ANY. That will make a huge difference.

2. The same line 33 - You have it as a trigger (the orange lightening bolt in the left margin). So every time one of your contacts changes state, it may break out of the repeat loop and start the piston at the top again.

You can certainly merge these two pistons together, or not. It’s your preference. I like to keep my “open door” and “closed door” pistons separate. They are just easier for me to debug that way. You may also have the same ALL or ANY problem in the second piston.

[Pantheon]

I loaded your first piston. You have line 33 as ANY. Is that your intent?

With the way you have it now, if ANY of your GarageDoors contacts changes to closed, the repeat/until loop will end, possibly with other contacts still open.