Piston is not repeating or triggering

Bboy486 · 2020-03-20 19:29:24 UTC

1) Give a description of the problem
The push notification is not repeating (when the light remains on) and the trigger of stay any of home, away or vacation is not triggering.

2) What is the expected behaviour?
Piston will repeat the push until the light is off.

3) What is happening/not happening?
See #1

**4) Post a Green Snapshot of the

5) Attach logs after turning logging level to Full

Logs

3/20/2020, 12:32:08 PM +145ms
+0ms ╔Received event [Casa de Pines].time = 1584732729202 with a delay of -1058ms
+287ms ║Runtime (51686 bytes) successfully initialized in 242ms (v0.3.110.20191009) (286ms)
+288ms ║╔Execution stage started
+317ms ║║Executed virtual command setVariable (3ms)
+337ms ║║Executed virtual command sendPushNotification (17ms)
+340ms ║║Executed virtual command setState (0ms)
+344ms ║║Arabella RGBW was left on for more than 2 minutes @12:32 PM 20-Mar-20 MST
+345ms ║║Executed virtual command log (1ms)
+348ms ║╚Execution stage complete. (60ms)
+349ms ╚Event processed successfully (349ms)
3/20/2020, 12:30:08 PM +218ms
+0ms ╔Received event [Casa de Pines].time = 1584732609359 with a delay of -1141ms
+942ms ║Runtime (51686 bytes) successfully initialized in 422ms (v0.3.110.20191009) (940ms)
+943ms ║╔Execution stage started
+988ms ║╚Execution stage complete. (46ms)
+989ms ║Setting up scheduled job for Fri, Mar 20 2020 @ 12:32:09 PM MST (in 119.995s)
+998ms ╚Event processed successfully (998ms)
3/20/2020, 12:29:38 PM +998ms
+1ms ╔Received event [Casa de Pines].test = 1584732578998 with a delay of 0ms
+327ms ║Runtime (51680 bytes) successfully initialized in 271ms (v0.3.110.20191009) (324ms)
+328ms ║╔Execution stage started
+382ms ║╚Execution stage complete. (54ms)
+392ms ║Setting up scheduled job for Fri, Mar 20 2020 @ 12:30:09 PM MST (in 29.97s)
+401ms ╚Event processed successfully (401ms)

ike2018 · 2020-03-20 19:33:01 UTC

I’d structure this piston a bit different.

Use one trigger as the MAIN IF BLOCK trigger (in repeat)

Repeat
   IF {light} switch stays on for {timelimit} minutes (main trigger)
       Then 
        IF Location is vacation, awat, home
        AND 
        IF Time is between X and Y
        Then 
        Do this do that

Bboy486 · 2020-03-20 20:15:35 UTC

Thank you, I will give that a try.

EDIT - Did not work. It worked when I tested but did not repeat or trigger by itself.

ike2018 · 2020-03-20 20:38:34 UTC

Line 34 should be a condition not a trigger though,

Pantheon · 2020-03-20 22:37:34 UTC

Repeat
Do This…
Until (what condition will terminate the Repeat?)

Bboy486 · 2020-03-21 00:52:44 UTC

I switched it to a condition but the same results

Bboy486 · 2020-03-21 00:53:05 UTC

What do you mean? It should terminate when the light is off

Pantheon · 2020-03-21 01:06:00 UTC

You do not have a condition defined in your Until statement to terminate the loop.

Pantheon · 2020-03-21 01:29:09 UTC

You MAY need a trigger at the top of you piston to initiate your repeat until. I don’t think that the Repeat Until can be initiated with a trigger from within the loop. Not sure about this one though. I have not tested it.

Execute
  IF X is true    <- Trigger
    Then
      Do
      Repeat
        Do Stuff
      Until Condition is false
  END IF
  Do other stuff
End Execute

Bboy486 · 2020-03-21 02:43:57 UTC

Isn’t the light staying on a trigger? I also tried an and location mode stay home, night and that didn’t trigger the piston

Pantheon · 2020-03-21 03:03:16 UTC

I don’t think that you want to trigger a Repeat-Until from within the loop.

IF RGB Bulb 1's switch stays on for 2 minutes   <- Trigger
  Then
    Repeat
      Do Stuff
    Until RGB Bulb 1's switch is off

But you will need a WAIT inside the repeat to keep from firing off PUSH notifications every milisecond that the repeat loop is executed. And using WAITS with repeat-until loops can get messy.

Bboy486 · 2020-03-21 03:26:29 UTC

Ok I think I get what you mean. Is there an alternative to the wait. I finally got the notifications to work but as you mentioned I am getting the pushes every other sec.

ike2018 · 2020-03-21 03:51:08 UTC

great catch… i missed that part.

Pantheon · 2020-03-21 11:36:30 UTC

Others here may have a better solution, but I would use a WAIT right now and see how it works for you.

Bboy486 · 2020-03-21 15:46:21 UTC

I meant the wait isn’t working with the changes.

Pantheon · 2020-03-21 17:10:44 UTC

Will you post a green shot of your piston?

Bboy486 · 2020-03-21 18:29:20 UTC

I have been testing the wait which is why there are two. Neither works.

Oddly enough, another piston I have uses a device local variable an even though the piston executes it doesn’t do anything to the devices within the list. Maybe these are related.

Pantheon · 2020-03-21 18:40:07 UTC

Can you try something for me. I have had difficulty putting my devices into a variable and using the variable name in the code (like your line #17). Can you test just one light and replace lines #25, #33, #48 with a single light device name and not a variable? Then test that one light and include the log here.

Bboy486 · 2020-03-21 18:43:17 UTC

I can but to be clear. I am getting notifications when I run the test (on this lastest piston) but the notifications repeat (as you mentioned previously).

I wonder if I have to save the device lists into a variable similar to my question a few years ago here. Variable loops in notification piston

Ex. I was able to get this piston to turn off the lights but only when I used individual bulbs in the piston and not use the device list.

3/21/2020, 11:43:50 AM +41ms
+1ms ╔Received event [3rd SYLVANIA BR30 RGBW].switch = off with a delay of 195ms
+9546ms ║Piston waited at a semaphore for 9266ms
+9549ms ║Runtime (52467 bytes) successfully initialized in 9498ms (v0.3.110.20191009) (9546ms)
+9550ms ║╔Execution stage started
+9585ms ║╚Execution stage complete. (36ms)
+9586ms ╚Event processed successfully (9586ms)
3/21/2020, 11:43:49 AM +966ms
+1ms ╔Received event [2nd SYLVANIA BR30 RGBW].switch = off with a delay of 252ms
+9560ms ║Piston waited at a semaphore for 9269ms
+9563ms ║Runtime (52467 bytes) successfully initialized in 9509ms (v0.3.110.20191009) (9561ms)
+9564ms ║╔Execution stage started
+9602ms ║╚Execution stage complete. (38ms)
+9603ms ╚Event processed successfully (9603ms)
3/21/2020, 11:43:49 AM +199ms
+0ms ╔Received event [Casa de Pines].time = 1584816230405 with a delay of -1207ms
+307ms ║Runtime (52403 bytes) successfully initialized in 252ms (v0.3.110.20191009) (306ms)
+308ms ║╔Execution stage started
+341ms ║║Executed [1st SYLVANIA BR30 RGBW].off (3ms)
+356ms ║║Executed [2nd SYLVANIA BR30 RGBW].off (14ms)
+370ms ║║Executed [3rd SYLVANIA BR30 RGBW].off (12ms)
+1239ms ║║Executed [1st SYLVANIA BR30 RGBW].off (4ms)
+1244ms ║║Executed [2nd SYLVANIA BR30 RGBW].off (3ms)
+1248ms ║║Executed [3rd SYLVANIA BR30 RGBW].off (4ms)
+1251ms ║╚Execution stage complete. (943ms)
+1252ms ╚Event processed successfully (1252ms)

Pantheon · 2020-03-21 18:48:01 UTC

I have had the same experience.

So it is working. Good. Maybe making the change to the device list as you have suggested will work. I am interested to see if it does!